lkml.org 
[lkml]   [2005]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/23] reboot-fixes
    Hi!

    > > > > > Good question. I'm not certain if Pavel intended to add
    > > > > > device_suspend(PMSG_FREEZE) to the reboot path. It was
    > > > > > there in only one instance. Pavel comments talk only about
    > > > > > the suspend path.
    > > > >
    > > > > Yes, I think we should do device_suspend(PMSG_FREEZE) in reboot path.
    > > >
    > > > Why?
    > >
    > > Many bioses are broken; if you leave hardware active during reboot,
    > > they'll hang during reboot. It is so common problem that I think that
    > > only sane solution is make hardware quiet before reboot.
    >
    > Sorry for my slow reply.
    >
    > If I remember correctly PMSG_FREEZE was intended solely for stopping
    > activity when suspend to disk implementations are about to do their

    Well, I think that PMSG_FREEZE can be handy when we want to stop
    activity for other reasons, too...

    > atomic copies. I thought that ide reacts to this message by putting a
    > hold on queues, but doesn't otherwise do anything to prepare a drive for
    > a restart. If that's true, using FREEZE here isn't going to stop drives
    > from doing their emergency shutdown actions. Don't we need PMSG_SUSPEND
    > instead?

    Spinning disk down is not neccessary for reboot. Users will be angry
    if we do it before reboot...
    Pavel
    --
    if you have sharp zaurus hardware you don't need... you know my address
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-08-04 23:58    [W:0.047 / U:1.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site