Messages in this thread | | | Date | Tue, 30 Aug 2005 19:54:48 -0400 | From | Mark Lord <> | Subject | Re: [PATCH] libata: add ATAPI module option |
| |
Jeff Garzik wrote: > > -#ifndef ATA_ENABLE_ATAPI > - if (unlikely(dev->class == ATA_DEV_ATAPI)) > - return NULL; > -#endif > + if (atapi_enabled) { > + if (unlikely(dev->class == ATA_DEV_ATAPI)) > + return NULL; > + } ..
Is that if-stmt the right way around? At first glance, I'd expect it to read:
if (!atapi_enabled) { ...
Cheers! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |