Messages in this thread | | | From | Daniel Phillips <> | Subject | Re: [RFC][PATCH 3 of 4] Configfs is really sysfs | Date | Tue, 30 Aug 2005 19:18:15 -0400 |
| |
On Tuesday 30 August 2005 19:06, Stephen Hemminger wrote: > On Wed, 31 Aug 2005 08:59:55 +1000 > > Daniel Phillips <phillips@istop.com> wrote: > > Configfs rewritten as a single file and updated to use kobjects instead > > of its own clone of kobjects (config_items). > > Some style issues: > Mixed case in labels
I certainly agree. This is strictly for comparison purposes and so I did not clean up the stylistic problems from the original... this time.
> Bad identation
I did lindent it however :-)
> > + Done: > > Why the mixed case label?
It shall die.
> > +void config_group_init_type_name(struct kset *group, const char *name, > > struct kobj_type *type) +{ > > + kobject_set_name(&group->kobj, name); > > + group->kobj.ktype = type; > > + config_group_init(group); > > +} > > Use tabs not one space for indent.
Urk. Kmail did that to me, it has been broken that way for a year or so. I will have to repost the whole set from a mailer that works.
Regards,
Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |