Messages in this thread | | | Subject | RE: [PATCH] Automatically enable bigsmp when we have more than 8 CPUs | Date | Wed, 3 Aug 2005 07:48:18 -0700 | From | "Pallipadi, Venkatesh" <> |
| |
>-----Original Message----- >From: Andi Kleen [mailto:ak@suse.de] >Sent: Wednesday, August 03, 2005 3:20 AM >To: Pallipadi, Venkatesh >Cc: Andrew Morton; Andi Kleen; Shah, Rajesh; linux-kernel >Subject: Re: [PATCH] Automatically enable bigsmp when we have >more than 8 CPUs > >On Thu, Jul 28, 2005 at 11:51:42AM -0700, Venkatesh Pallipadi wrote: >> smp_found_config = 1; >> - clustered_apic_check(); > >Removing that here will break x86-64. >
Yes. Ashok sent another patch to fix this part. Lkml subjectline [patch 1/8] x86_64: Reintroduce clustered_apic_check() for x86_64
>> >> +#ifdef CONFIG_X86_GENERICARCH >> + generic_apic_probe(*cmdline_p); >> +#endif > >This move looks risky because ACPI can already switch subarchs. Are you >sure the command line option still works? Testing on summit and es7000 >would be good. >
Yes. We also saw some potential issues with ACPI ioapic detection on other sub-archs after this change, late yesteraday. I am right now reworking this patch.
Andrew: Until I send a reworked patch can you remove these two patces from the mm. Thanks. 1) [PATCH] Automatically enable bigsmp when we have more than 8 CPUs 2) [patch 1/8] x86_64: Reintroduce clustered_apic_check() for x86_64
Thanks, Venki - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |