[lkml]   [2005]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Ignore disabled ROM resources at setup

    > pci_map_rom "sees" that the resource is unassigned by testing the parent
    > pointer, and calls pci_assign_resource() which, with this new patch,
    > will do nothing.

    Ok, it won't do nothing in fact. It's worse. It will return 0 (success),
    will actually assign a completely new address to the resource, will
    update the resource structure ... and will _not_ update the PCI resource
    BAR for the ROM.

    That is very bad and definitely not what you want, wether it's ppc, x86
    or anything else. Either fail (don't assign the resource at all) or if
    you assign it, keep the BAR in sync with the struct resource.

    Also, why do we re-allocate a new address for it ? It's been properly
    allocated a non-conflicting address by the firmware ... That's a big
    problem I have with our common code as well.
    pci_assign_unassigned_resource() doesn't do what it claims: it will
    re-assign all resources, not only the unassigned ones, at least as soon
    as it spots a brige, and pci_assign_resource() here called by
    pci_map_rom() will re-assign even if the address there was already

    At this point, i'm not sure what the proper fix it.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-08-30 05:27    [W:0.021 / U:7.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site