Messages in this thread | | | Subject | RE: [PATCH] acpi: Handle cpu_index greater than 256 properly in processor_core.c | Date | Mon, 29 Aug 2005 14:59:25 -0700 | From | "Pallipadi, Venkatesh" <> |
| |
>-----Original Message----- >From: Ingo Oeser [mailto:ioe-lkml@rameria.de] >Sent: Saturday, August 27, 2005 5:23 AM >To: Pallipadi, Venkatesh >Cc: linux-kernel; Andrew Morton; Brown, Len >Subject: Re: [PATCH] acpi: Handle cpu_index greater than 256 >properly in processor_core.c > >Hi Venkatesh, > >On Saturday 27 August 2005 02:07, Venkatesh Pallipadi wrote: >> Fix convert_acpiid_to_cpu function to handle cpu_index >greater than 256. This >> patch also prevents a warning in IA64 cross-compile of this file >> (drivers/acpi/processor_core.c:517: warning: comparison is >always false due >> to limited range of data type). > >Why don't you just change the datatype to "unsigned int" and >the return failure value to NR_CPUS? > >That reduces the code changes and leaves the code quite clear. >It should also reduce compiled code size by some bytes, but I'm not >sure about that one. >
Yes. It can be done. But to me, the current patch is more cleaner. I don't think we should mix up the cpu_index and error return value.
Thanks, Venki
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |