Messages in this thread | | | Date | Fri, 26 Aug 2005 20:03:39 +0100 | From | Al Viro <> | Subject | Re: [patch 1/2] Fixup symlink function pointers for hppfs [for 2.6.13] |
| |
On Fri, Aug 26, 2005 at 04:57:44PM +0200, blaisorblade@yahoo.it wrote: > > From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> > > Update hppfs for the symlink functions prototype change. > Should be trivial, but please verify it's correct. > > Yes, I know the code I leave there is still _bogus_, see next patch for this.
Assuming that the next patch was "hppfs: fix symlink error path", you've still left BS in there -
> proc_file = dentry_open(dget(proc_dentry), NULL, O_RDONLY);
is obviously wrong; at the very least you need vfsmount in there. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |