Messages in this thread | | | Date | Wed, 24 Aug 2005 12:08:57 +0200 | From | Adrian Bunk <> | Subject | Re: [RFC: 2.6 patch] #include <asm/irq.h> in interrupt.h |
| |
On Wed, Aug 24, 2005 at 10:22:50AM +0100, Christoph Hellwig wrote: > On Wed, Aug 24, 2005 at 10:57:50AM +0200, Adrian Bunk wrote: > > If #includ'ing interrupt.h should be enough for getting the prototype of > > e.g. enable_irq() on all architectures, we need this patch. > > Per defintion you need to include <asm/irq.h> right now. I'd like to change > that to <linux/interrupt.h>, but not my including <asm/irq.h> there. > We should just make the prototypes in <linux/interrupt.h> unconditional > and get rid of the macro/inline tricks some architectures do, these calls > aren't exactly fastpathes where that matters.
Looking at 2.6.13-rc6-mm2, the only architectures with own enable_irq() implementations are m68knommu and sparc.
On m68knommu, enable_irq() does nothing unless a hook is used that has no in-kernel users.
The 32bit sparc arch seems to be the only arch doing funky things.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |