Messages in this thread | | | Subject | Re: VIA Rhine ethernet driver bug (reprise...) | From | Lee Revell <> | Date | Wed, 24 Aug 2005 11:50:23 -0400 |
| |
On Tue, 2005-08-23 at 12:21 +0300, Denis Vlasenko wrote: > My suggestion was, and still is: > > >Since it happens less than once a day, why not just add a code > >to reset the NIC completely in this case, like it is > >typically done in tx_timeout handlers of many NICs, and forget about > it? > > Do you see any problems in this approach?
Yes, hacks like that often causes a long non-preemptible section because code that was only intended to run on boot now gets hung off a timer and can run in the middle of real work.
I have an EPIA 6000 with a via Rhine and I've never seen this bug, so it must be something specific to your network. Better to find the bug and fix it rather than add stupid hacks.
Lee
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |