Messages in this thread Patch in this message | | | Date | Mon, 22 Aug 2005 16:40:50 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: rc6 keeps hanging and blanking displays |
| |
On Tue, 23 Aug 2005, Dave Airlie wrote: > > Can we revert the PCI assign resources patch?
I'd rather not revert the whole PCI assign thing, because it's good.
But disabling the ROM assignment might be a good idea. Almost nobody ever really wants to assign the ROM anyway, and there are cards where there are some strange rules about ROM alignment (read: doesn't follow spec).
That may be the problem with MGA - I think some gfx cards used the same decoder for ROM and for the video RAM aperture, so that you were supposed to only enable ROM when the RAM thing was quiescent or something, and always use the same address too (the current code doesn't _enable_ the ROM, but I think it allocates and programs the base address. Which should be harmless, but..).
Ivan? Does something like this make a difference?
Linus
--- diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c --- a/drivers/pci/setup-res.c +++ b/drivers/pci/setup-res.c @@ -52,10 +52,12 @@ pci_update_resource(struct pci_dev *dev, if (resno < 6) { reg = PCI_BASE_ADDRESS_0 + 4 * resno; +#if 0 } else if (resno == PCI_ROM_RESOURCE) { new |= res->flags & IORESOURCE_ROM_ENABLE; reg = dev->rom_base_reg; } else { +#endif /* Hmm, non-standard resource. */ return; /* kill uninitialised var warning */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |