Messages in this thread | | | Date | Thu, 11 Aug 2005 13:33:36 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] latency logger for realtime-preempt-2.6.12-final-V0.7.51-30 |
| |
* Daniel Walker <dwalker@mvista.com> wrote:
> On Thu, 2005-08-04 at 15:52 +0200, Ingo Molnar wrote: > > > would be nice to clean up the impact of the latency-histogram code some > > more though: e.g. the #ifdef jungle check_critical_timing() is > > disgusting. Could be cleaned up by always recording the latency_type > > being currently traced into a new tr->latency_type field, and then using > > that in check_critical_timing(). > > the code appears to be adding ifdefs to make preempt_max_latency work > like preempt_threshold , I think all the nasty ifdefs could go away if > we just made it use preempt_threshold .. Plus it logs latency during > boot up cause preempt_max_latency equals zero .
yes. Would be nice to have these cleanups too. The #ifdef impact of the LATENCY_HIST code is quite high at the moment, and it needs to be decreased.
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |