Messages in this thread | | | Date | Fri, 12 Aug 2005 00:06:55 +1000 | From | Nick Piggin <> | Subject | Re: [patch 6/7] mm: lockless pagecache |
| |
Hi Pekka,
Pekka Enberg wrote: > Hi Nick, > > On 8/11/05, Nick Piggin <nickpiggin@yahoo.com.au> wrote: > >>+unsigned find_get_pages_nonatomic(struct address_space *mapping, pgoff_t start, >>+ unsigned int nr_pages, struct page **pages) >>+{ >>+ unsigned int i; >>+ unsigned int ret; > > > Rename to nr_pages? > > >>+ unsigned int ret2; > > > Rename to ret? > > >>+ >>+ /* >>+ * We do some unsightly casting to use the array first for storing >>+ * pointers to the page pointers, and then for the pointers to >>+ * the pages themselves that the caller wants. >>+ */ >>+ rcu_read_lock(); >>+ ret = radix_tree_gang_lookup_slot(&mapping->page_tree, >>+ (void ***)pages, start, nr_pages); >>+ ret2 = 0; >>+ for (i = 0; i < ret; i++) { > > > Pretty please? :-) >
Hey that's not actually a bad idea.
I was thinking about how to make that function nicer, but the voices in my head just kept telling me to rename 'i' to 'ret3' ;)
So, thanks!
Nick
-- SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |