[lkml]   [2005]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: share/private/slave a subtree

On Fri, 8 Jul 2005, Pekka J Enberg wrote:

> > You can't do that with defines?
> Sure you can but have you ever tried to figure out where a group of #define
> enumerations end?

Comments? Newlines?

> Enums are a natural language construct for grouping related
> constants so why not use it?

So are defines.

> Bottom line, there are few advantages to using enums rather than #defines
> which is why they are IMHO preferred for new code.

Are the advantages big enough to actively discourage defines? It's nice
that you do reviews, but please leave some room for personal preferences.
If the code is correct and perfectly readable, it doesn't matter whether
to use defines or enums. Unless you also intent to also debug and work
with that code, why don't leave the decision to the author?

bye, Roman
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-07-08 15:37    [W:0.111 / U:3.060 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site