lkml.org 
[lkml]   [2005]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] char: Add Dell Systems Management Base driver
On Tue, Jul 05, 2005 at 11:17:03PM -0500, Greg KH wrote:
> > +static void dcdbas_device_release(struct device *dev)
> > +{
> > + /* nothing to release */
> > +}
>
> This is a symptom of a broken driver.
>
> Hm, I wonder if there's some way for the compiler to check the fact that
> a function pointer passed to another function, is really a null
> function. That would stop this kind of nonsense...

There are other drivers in the kernel tree with null device release functions.

>
> I'm sure I commented on this driver already, yet, I never got a response
> and the code is not changed. Is there some reason for this? That's a
> sure way to prevent your patch from ever being applied...

This is the first comment on the release function. The code has been changing in response to comments from you and others. We'll continue to make changes as needed.

Doug
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-07 05:24    [W:0.063 / U:3.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site