lkml.org 
[lkml]   [2005]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Linux 2.6.13-rc2
On Wed, Jul 06, 2005 at 08:42:16AM -0700, Linus Torvalds wrote:
>
>
> On Wed, 6 Jul 2005, Eyal Lebedinsky wrote:
> >
> > CC [M] sound/pci/bt87x.o
> > sound/pci/bt87x.c: In function `snd_bt87x_detect_card':
> > sound/pci/bt87x.c:807: error: `driver' undeclared (first use in this function)
> > sound/pci/bt87x.c:807: error: (Each undeclared identifier is reported only once
> > sound/pci/bt87x.c:807: error: for each function it appears in.)
> > sound/pci/bt87x.c: At top level:
> > sound/pci/bt87x.c:910: error: `driver' used prior to declaration
>
> This seems to be a thinko by Greg. That line got changed from
>
> supported = pci_match_device(snd_bt87x_ids, pci);
>
> to
>
> supported = pci_match_device(driver, pci);
>
> but as far as I can tell it _should_ be
>
> supported = pci_match_id(snd_bt87x_ids, pci);

No, I wanted it to be "driver", but forgot to build the code, sorry.
Try the following patch instead:

thanks,

greg k-h

-------------------

Fixes bt87x.c build problem.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
sound/pci/bt87x.c | 2 ++
1 files changed, 2 insertions(+)

--- gregkh-2.6.orig/sound/pci/bt87x.c 2005-07-06 08:48:29.000000000 -0700
+++ gregkh-2.6/sound/pci/bt87x.c 2005-07-06 08:48:54.000000000 -0700
@@ -798,6 +798,8 @@
{0x270f, 0xfc00}, /* Chaintech Digitop DST-1000 DVB-S */
};

+static struct pci_driver driver;
+
/* return the rate of the card, or a negative value if it's blacklisted */
static int __devinit snd_bt87x_detect_card(struct pci_dev *pci)
{



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-07 05:20    [W:0.062 / U:1.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site