lkml.org 
[lkml]   [2005]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix crash on boot in kmalloc_node IDE changes
On Wed, 6 Jul 2005 16:35:11 +0200
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:

> On 7/6/05, Andi Kleen <ak@suse.de> wrote:
> > > drive->hwif check is redundant, please remove it
> >
> > It's not. My first version didn't have it but it still crashed.
> > It's what actually prevents the crash.
> > I also don't know why, but it's true.
>
> very weird as HWIF(drive) == drive->hwif:
>
> ide_hwif_t *hwif = HWIF(drive);
>
> ...
>
> q = blk_init_queue_node(do_ide_request, &ide_lock,
> pcibus_to_node(drive->hwif->pci_dev->bus));
^^^^^^^^^^^^^^

I oops on that one. Maybe it takes the early return.

> if (!q)
> return 1;
>
> ...
>
> if (!hwif->rqsize) {
>
> you should OOPS here


I would appreciate if some form of this patch is merged asap because it breaks
booting on my test machines.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-07 02:20    [W:0.039 / U:12.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site