Messages in this thread | | | Date | Wed, 6 Jul 2005 16:13:10 -0700 | From | Greg KH <> | Subject | Re: [patch 2.6.13-rc2] yet another fix for setup-bus.c/x86 merge |
| |
On Thu, Jul 07, 2005 at 03:07:56AM +0400, Ivan Kokshaysky wrote: > There is a slight disagreement between setup-bus.c code and traditional > x86 PCI setup wrt which recourses are invalid vs resources that are > free for further allocations. > Precisely, in the setup-bus.c, if we failed to allocate some resource, > we nullify "start" and "flags" fields, but *not* the "end" one. > But x86 pcibios_enable_resources() does the following check: > if (!r->start && r->end) { > printk(KERN_ERR "PCI: Device %s not available because of resource collisions\n", pci_name(dev)); > return -EINVAL; > which means that the device owning the offending resource cannot be > enabled. > In particular, this breaks cardbus behind the normal decode p2p bridge - > the cardbus code from setup-bus.c requests rather large IO and MEM windows, > and if it fails, the socket is completely unavailable. Which is wrong, as > the yenta code is capable to allocate smaller windows. > > Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Thanks Ivan for finding this so quickly.
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |