Messages in this thread | | | Date | Mon, 1 Aug 2005 00:56:50 +0400 | From | Alexey Dobriyan <> | Subject | Re: [PATCH 2.6] (10/11) hwmon vs i2c, second round |
| |
One nitpicking comment and two observations:
On Sun, Jul 31, 2005 at 10:02:24PM +0200, Jean Delvare wrote: > I see very little reason why vid_from_reg and vid_to_reg are inlined. > The former is not exactly short,
1) and their arguments aren't known at compile time,
[Compiler can optimise them away _completely_ if both arguments are known at compile time or significantly of only one is known.]
> and they are never called in speed critical areas. Uninlining them should > cause little performance loss if any, and saves a signficant space and > compilation time as well.
2) VID_FROM_REG is asking for removal from lm85.
3) vid_to_reg is used only by atxp1.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |