Messages in this thread | | | Subject | RE: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R | Date | Fri, 29 Jul 2005 14:55:36 -0700 | From | "Gaston, Jason D" <> |
| |
This define is not actually used anywhere that I know of. I just wanted to be consistent and correct, following what was previously done. I have been wondering if I should be adding devices to the pci_ids.h file that are not being currently used. It seems like most drivers are not using these defines and are just using the DID's directly. In the future, should I only be add devices that are actually using the defines somewhere?
Thanks,
Jason
>-----Original Message----- >From: Jeff Garzik [mailto:jgarzik@pobox.com] >Sent: Friday, July 29, 2005 2:49 PM >To: Gaston, Jason D >Cc: mj@ucw.cz; akpm@osdl.org; linux-kernel@vger.kernel.org >Subject: Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R > >Jason Gaston wrote: >> Hello, >> >> This patch adds the Intel ICH7R SATA RAID DID to the pci_ids.h file. >This patch was built against the 2.6.13-rc4 kernel. >> If acceptable, please apply. >> >> Thanks, >> >> Jason Gaston >> >> Signed-off-by: Jason Gaston <Jason.d.gaston@intel.com> >> >> --- linux-2.6.13-rc4/include/linux/pci_ids.h.orig 2005-07-29 >09:06:03.841520568 -0700 >> +++ linux-2.6.13-rc4/include/linux/pci_ids.h 2005-07-29 >09:06:42.256680576 -0700 >> @@ -2454,6 +2454,7 @@ >> #define PCI_DEVICE_ID_INTEL_ICH7_3 0x27c1 >> #define PCI_DEVICE_ID_INTEL_ICH7_30 0x27b0 >> #define PCI_DEVICE_ID_INTEL_ICH7_31 0x27bd >> +#define PCI_DEVICE_ID_INTEL_ICH7_4 0x27c3 >> #define PCI_DEVICE_ID_INTEL_ICH7_5 0x27c4 >> #define PCI_DEVICE_ID_INTEL_ICH7_6 0x27c5 >> #define PCI_DEVICE_ID_INTEL_ICH7_7 0x27c8 > >Where is this actually used? > >I purposefully do not use PCI_DEVICE_ID_xxx in my drivers, because I >feel that linux/pci_ids.h is constantly patched for little value. > >Device ids, unlike vendor ids, are largely single-use constants. > > Jeff > >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |