Messages in this thread | | | Date | Thu, 28 Jul 2005 10:31:58 +0200 | From | Pavel Machek <> | Subject | Re: [ACPI] Re: [Alsa-devel] [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (1/2) |
| |
Hi!
> > > > The following patch adds free_irq() and request_irq() to the suspend and > > > > resume, respectively, routines in the snd_intel8x0 driver. > > > > > > The patch looks OK to me although I have some concerns. > > > > > > - The error in resume can't be handled properly. > > > > > > What should we do for the error of request_irq()? > > > > > > - Adding this to all drivers seem too much. > > > > There's probably no other way. Talk to Len Brown. > > > > > We just need to stop the irq processing until resume, so something > > > like suspend_irq(irq, dev_id) and resume_irq(irq, dev_id) would be > > > more uesful? > > > > Its more complex than that. Irq numbers may change during resume. > > Hmm, then the patch looks wrong. It assumes that the irq number is > as same as before suspend.
> Sorry for ignorance, but, is only irq affected? Are the other > resources like ioport consistent after resume?
I think it is only irq, but Len, please take correct me if I'm wrong. Irq number can change during suspend/resume cycle, right?
Pavel -- teflon -- maybe it is a trademark, but it should not be. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |