Messages in this thread | | | Date | Thu, 28 Jul 2005 00:04:55 -0700 | From | Mitchell Blank Jr <> | Subject | Re: [PATCH] driver core: Add the ability to unbind drivers to devices from userspace |
| |
Greg KH wrote: > > + /* locate trailng white space */ > > + z = y = x; > > + while (y - buffer->page < count) { > > + y++; > > + z = y; > > + while (isspace(*y) && (y - buffer->page < count)) { > > + y++; > > + } > > + } > > + count = z - x; > > Hm, I _think_ this works, but I need someone else to verify this... > Anyone else?
It looks sane-ish to me, but also more complicated than need be. Why can't you just do something like:
while (count > 0 && isspace(x[count - 1])) count--;
-Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |