Messages in this thread Patch in this message | | | Date | Sat, 23 Jul 2005 23:07:08 +0200 (CEST) | From | Stefan Richter <> | Subject | Re: [2.6 patch] drivers/ieee1394/sbp2.c: fix warnings with -Wundef |
| |
On 22 Jul, Adrian Bunk wrote: > drivers/ieee1394/sbp2.c:202:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined > drivers/ieee1394/sbp2.c:207:7: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined > drivers/ieee1394/sbp2.c:2053:6: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined > drivers/ieee1394/sbp2.c:2623:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
Here is a minimally improved version of the patch. I kept your sign-off.
- - - - - - - - - - - - 8< - - - - - - - - - - - -
sbp2: fix compiler warnings with -Wundef
Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Index: linux-2.6.13-rc3/drivers/ieee1394/sbp2.c =================================================================== --- linux-2.6.13-rc3/drivers/ieee1394/sbp2.c (revision 1316) +++ linux-2.6.13-rc3/drivers/ieee1394/sbp2.c (working copy) @@ -171,10 +171,12 @@ /* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */ /* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */ -/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */ -/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */ /* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */ +/* increase to 1 for verbose logging, to 2 for even more logging */ +#define CONFIG_IEEE1394_SBP2_DEBUG 0 + + #ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS #define SBP2_ORB_DEBUG(fmt, args...) HPSB_ERR("sbp2(%s): "fmt, __FUNCTION__, ## args) static u32 global_outstanding_command_orbs = 0;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |