lkml.org 
[lkml]   [2005]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
    Hi,

    On Sat, 23 Jul 2005, Nishanth Aravamudan wrote:

    > set_current_state(TASK_{,UN}INTERRUPTIBLE);
    > schedule_timeout(msecs_to_jiffies(some_constant_msecs));
    >
    > just have an interface that allows
    >
    > schedule_timeout_msecs_{,un}interruptible(some_constant_msecs);
    >
    > and push the jiffies conversion to common code?

    What's wrong with just:

    schedule_timeout_{,un}interruptible(msecs_to_jiffies(some_constant_msecs));

    The majority of users use a constant, which can already be converted at
    compile tile.
    Additionally such an interface also had to return a ms value and instead
    of that constant conversion, the user is better off to work with jiffies
    directly.

    bye, Roman
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-07-23 19:05    [W:0.041 / U:29.320 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site