lkml.org 
[lkml]   [2005]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch,rfc] Support for touchscreen on sharp zaurus sl-5500
On 7/21/05, Pavel Machek <pavel@suse.cz> wrote:
> Hi!
>
> > > + set_task_state(tsk, TASK_UNINTERRUPTIBLE);
> > > + schedule_timeout(HZ / 100);
> > > + if (signal_pending(tsk))
> > > + break;
> >
> > You specifically allow SIGKILL, but then sleep uninterruptibly? And
> > then you check if signal_pending() :) I think you may want
> > TASK_INTERRUPTIBLE? Or, go one better and use msleep_interruptible(),
> > as I don't see any wait-queues in the immediate area of this code...
>
> Okay, I think this should be uninterruptible. The signal can be
> delivered during next interruptible sleep. Fixes.

Good point. But the signal_pending() check after that interruptible
sleep (which deterministically comes after this one) takes care of the
break, doesn't it? I guess you can (maybe already have done so...) get
rid of the signal_pending() check after the uninterruptible sleep. And
then go ahead and make this an msleep(10) call and the other one (in
the same function) an msleep_interruptible() call ;)

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-22 07:06    [W:0.024 / U:12.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site