Messages in this thread | | | Date | Sat, 2 Jul 2005 15:01:26 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq. |
| |
On Sat, 2 Jul 2005, David Woodhouse wrote: > > Zero _is_ a valid IRQ number.
Not for a "legacy irq" it ain't.
If the ACPI layer itself decides to use IRQ0, then that's fine, and that path hasn't changed at all.
However, if ACPI doesn't find any irq, and ends up just using whatever irq the device had for some legacy reason, then irq 0 just means "nobody set an irq".
Besides, we'll actually be returning 0 _anyway_. The only thing my patch fixes (and it _is_ a fix) is that we won't be stupidly thinking that we actually have a valid irq, and that we should turn it level-sensitive.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |