lkml.org 
[lkml]   [2005]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Ext2-devel] [RFC] [PATCH 2/4]delayed allocation for ext3
From
Date
On Sun, 2005-07-17 at 19:47 -0600, Andreas Dilger wrote:
> On Jul 17, 2005 10:40 -0700, Mingming Cao wrote:
> > @@ -373,6 +373,7 @@ struct ext3_inode {
> > #define EXT3_MOUNT_BARRIER 0x20000 /* Use block barriers */
> > #define EXT3_MOUNT_NOBH 0x40000 /* No bufferheads */
> > #define EXT3_MOUNT_QUOTA 0x80000 /* Some quota option set */
> > + #define EXT3_MOUNT_DELAYED_ALLOC 0xC0000 /* Delayed Allocation */
>
> This doesn't make sense. DELAYED_ALLOC == QUOTA | NOBH?

My fault. I will fix it.

>
> > + {Opt_delayed_alloc, "delalloc"},
>
> Is this a replacement for Alex's delalloc code? We also use delalloc for
> that code and if they are not interchangeable it will cause confusion
> about which one is in use.
>

Well, basically "delalloc" concept is same - whether we use it on
current ext3 layout or with new extent layout doesn't matter.


> > + if (test_opt(sb, DELAYED_ALLOC)) {
> > + if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) {
> > + printk(KERN_WARNING "EXT3-fs: Ignoring delall option - "
> > + "its supported only with writeback mode\n");
>
> Should be "ignoring delalloc option".

Yep.

Thanks,
Badari



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-19 02:36    [W:0.028 / U:13.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site