lkml.org 
[lkml]   [2005]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Apple USB Touchpad driver (new)
From
Date
Le mardi 12 juillet 2005 à 09:13 -0500, Dmitry Torokhov a écrit :
> Hi,
>
> On 7/12/05, Stelian Pop <stelian@popies.net> wrote:
> >
> > + dev->input.id.bustype = BUS_USB;
> > + dev->input.id.vendor = id->idVendor;
> > + dev->input.id.product = id->idProduct;
> > + dev->input.id.version = ATP_DRIVER_VERSION;
> > +
>
> Why don't we do what most of the other input devices and get version
> from the device too?

I guess we could, there is not much use for a local driver version
anyway.

> Actually we have this in input tree:
>
> static inline void
> usb_to_input_id(const struct usb_device *dev, struct input_id *id)

This cleans up a lot of code indeed. Too bad this is not upstream yet...

Stelian.
--
Stelian Pop <stelian@popies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-12 16:42    [W:1.326 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site