Messages in this thread | | | Date | Mon, 11 Jul 2005 12:47:32 +0200 | From | Vojtech Pavlik <> | Subject | Re: [PATCH] Apple USB Touchpad driver (new) |
| |
On Mon, Jul 11, 2005 at 02:15:49AM +0200, Peter Osterlund wrote:
> I took the liberty to modify the patch myself, making these changes: > > * Removed the extra filtering. > * Converted the "open" counter to an "open" flag. (It is still needed > by the atp_resume() function.) > * CodingStyle fixes. > > I have only compile tested this as I don't have access to the > hardware, so I don't know how well this works in practice. It's > possible that the "dev->h_count > 3" test in the old patch filtered > out spikes in the input signal. > > Also, it might be a good idea to compute an ABS_PRESSURE value instead > of hardcoding it to 100. I think the psum variable in > atp_calculate_abs() can be used, possibly after rescaling.
Stelian, can you check the patch, and if everything is OK, add your Signed-off-by: line?
> Signed-off-by: Peter Osterlund <petero2@telia.com> > --- > > Documentation/input/appletouch.txt | 120 +++++++++ > drivers/usb/input/Kconfig | 19 + > drivers/usb/input/Makefile | 1 > drivers/usb/input/appletouch.c | 461 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 601 insertions(+), 0 deletions(-)
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |