Messages in this thread Patch in this message | | | From | David Brownell <> | Subject | [patch 2.6.13-git] 8250 tweaks | Date | Mon, 11 Jul 2005 19:22:04 -0700 |
| |
Two small changes: make the IRQ name less generic, and stop whining about certain non-errors (details in the patch comments). Please merge.
- Dave
Make the 8250 UART driver register its IRQ using a label that's more appropriate ... it's an 8250 UART, not one of dozens of other kind of serial link (I2C, SPI, USB, McBSP, I2S, non-8250 UART, USART, SSP, MicroWire, PS/2 kbd/mouse/touchpad, MCSI, HDQ/1-Wire, ... etc).
Also, make it stop whining when one of the platform serial ports has been disabled, e.g. because a given board doesn't wire it out.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
--- o26.orig/drivers/serial/8250.c 2005-07-11 18:41:03.000000000 -0700 +++ o26/drivers/serial/8250.c 2005-07-11 18:58:26.000000000 -0700 @@ -1317,7 +1317,7 @@ static int serial_link_irq_chain(struct spin_unlock_irq(&i->lock); ret = request_irq(up->port.irq, serial8250_interrupt, - irq_flags, "serial", i); + irq_flags, "uart_8250", i); if (ret < 0) serial_do_unlink(i, up); } @@ -2331,6 +2331,8 @@ static int __devinit serial8250_probe(st memset(&port, 0, sizeof(struct uart_port)); for (i = 0; p && p->flags != 0; p++, i++) { + if (!p->iobase && !p->membase) + continue; port.iobase = p->iobase; port.membase = p->membase; port.irq = p->irq; | |