lkml.org 
[lkml]   [2005]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] compress the stack layout of do_page_fault(), x86
On Sat, Jul 09, 2005 at 09:42:20PM +0200, Ingo Molnar wrote:
>
> * Andi Kleen <ak@suse.de> wrote:
>
> > Ingo Molnar <mingo@elte.hu> writes:
> > >
> > > +static void force_sig_info_fault(int si_signo, int si_code,
> > > + unsigned long address, struct task_struct *tsk)
> >
> > This won't work with a unit-at-a-time compiler which happily inlines
> > everything static with only a single caller. Use noinline
>
> this function has two callers.

Even then it's still better to mark it noinline, otherwise
a different inlining algorithm in a new compiler might do the wrong
thing. It's also useful documentation.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-10 18:18    [W:0.042 / U:5.204 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site