lkml.org 
[lkml]   [2005]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Apple USB Touchpad driver (new)
On Sun, Jul 10, 2005 at 12:32:45AM +0200, Peter Osterlund wrote:
> Stelian Pop <stelian@popies.net> writes:
>
> > +Synaptics re-detection problems:
> > +--------------------------------
> > +
> > +The synaptics X11 driver tries to re-open the touchpad input device file
> > +(/dev/input/eventX) each time you change from text mode back to X11. If the
> > +input device file does not exist at this precise moment, the synaptics driver
> > +will give up searching for a touchpad, permanently. You will need to restart
> > +X11 if you want to reissue a scan.
>
> I think this particular problem is fixed by the following patch to the
> X driver:
>
> --- synaptics.c.old 2005-07-10 00:09:02.000000000 +0200
> +++ synaptics.c 2005-07-10 00:09:12.000000000 +0200
> @@ -524,6 +524,11 @@
>
> local->fd = xf86OpenSerial(local->options);
> if (local->fd == -1) {
> + xf86ReplaceStrOption(local->options, "Device", "");
> + SetDeviceAndProtocol(local);
> + local->fd = xf86OpenSerial(local->options);
> + }
> + if (local->fd == -1) {
> xf86Msg(X_WARNING, "%s: cannot open input device\n", local->name);
> return !Success;
> }
>
> > +static int atp_calculate_abs(int *xy_sensors, int nb_sensors, int fact) {
>
> I think this CodingStyle violation is quite annoying, because it
> prevents emacs from finding the beginning of the function. It should
> be written like this:
>
> static int atp_calculate_abs(int *xy_sensors, int nb_sensors, int fact)
> {

Agreed, this should be fixed.

--
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-10 14:01    [W:0.087 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site