lkml.org 
[lkml]   [2005]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/82] changing CONFIG_LOCALVERSION rebuilds too much, for no good reason.
Olaf Hering wrote:
> The following series of patches removes almost all inclusions
> of linux/version.h. The 3 #defines are unused in most of the touched files.
>
> A few drivers use the simple KERNEL_VERSION(a,b,c) macro, which is unfortunatly
> in linux/version.h. This define moved to linux/utsname.h
>
> There are also lots of #ifdef for long obsolete kernels, this will go as well.

I agree with most of the changes (and I say "most" simply because I
haven't reviewed all of them), but it would be better to coalesce these
100+ patches into much smaller patch clumps.

"split your patches up" mantra can get taken too far. We want -logical
changes- separated out, and your patches are largely a single logical
change (remove old code).

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-11 00:36    [W:0.329 / U:0.936 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site