lkml.org 
[lkml]   [2005]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] device-mapper: dm-raid1: Limit bios to size of mirror region
Date
On Fri July 1 2005 2:26 am, Andrew Morton wrote:
> Alasdair G Kergon <agk@redhat.com> wrote:
> > --- diff/drivers/md/dm-raid1.c 2005-06-17 20:48:29.000000000 +0100
> > +++ source/drivers/md/dm-raid1.c 2005-06-29 21:12:13.000000000 +0100
> > @@ -1060,6 +1060,7 @@
> > }
> >
> > ti->private = ms;
> > + ti->split_io = ms->rh->region_size;
> >
> > r = kcopyd_client_create(DM_IO_PAGES, &ms->kcopyd_client);
> > if (r) {
>
> Ahem.
>
> drivers/md/dm-raid1.c: In function `mirror_ctr':
> drivers/md/dm-raid1.c:1072: invalid type argument of `->'
>
> ---
> devel/drivers/md/dm-raid1.c~device-mapper-dm-raid1-limit-bios-to-size-of-mi
>rror-region-fix 2005-07-01 00:25:26.000000000 -0700 +++
> devel-akpm/drivers/md/dm-raid1.c 2005-07-01 00:25:26.000000000 -0700 @@
> -1060,7 +1060,7 @@ static int mirror_ctr(struct dm_target *
> }
>
> ti->private = ms;
> - ti->split_io = ms->rh->region_size;
> + ti->split_io = ms->rh.region_size;
>
> r = kcopyd_client_create(DM_IO_PAGES, &ms->kcopyd_client);
> if (r) {
>
> How well tested was this?

Ehh...oops...sorry about that. :(

Zhao, you reported this issue originally. Have you been able to test this yet
to see if it fixes the corruption problem you were describing? Or can you
give us a test-case that I can run?

--
Kevin Corry
kevcorry@us.ibm.com
http://www.ibm.com/linux/
http://evms.sourceforge.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-01 15:13    [W:0.034 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site