Messages in this thread | | | Date | Fri, 1 Jul 2005 19:08:58 +0200 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: Re: PATCH for ide_floppy |
| |
On 7/1/05, Manfred.Scherer.Mhm@t-online.de <Manfred.Scherer.Mhm@t-online.de> wrote: > it's not really a performance issue but more a timeout issue. > 'IDEFLOPPY_TICKS_DELAY 60' avoids error messages in /var/log/messages > like 'reset ide ...'. > Without the idefloppy_timer_expiry the data transfer to the ide-floppy > is pending a long time between some transfer of data. The floppy LED > indicated this too. > With kernel 2.4.x I've never had this problem.
This seems related to 2.4 -> 2.6 HZ change.
> > @@ -317,7 +324,13 @@ > > unsigned long flags; > > } idefloppy_floppy_t; > > > > +#if 0 > > #define IDEFLOPPY_TICKS_DELAY 3 /* default delay for ZIP 100 > */ > > +#define IDEFLOPPY_TICKS_DELAY 6 /* default delay for ZIP 100 > > --ms 2005/01/01 */ > > +#define IDEFLOPPY_TICKS_DELAY 12 /* default delay for ZIP 100 > > --ms 2005/01/01 */ > > +#endif > > +#define IDEFLOPPY_TICKS_DELAY 60 /* default delay for ZIP 100 > > --ms 2005/01/07 */ > > +
"ticks" delay should be expressed using HZ
#define IDEFLOPPY_TICKS_DELAY HZ/20
for 50msec delay (N.B. the comment in the code about default delay being 50msec also seems wrong - it was more like ~33msec in 2.4)
Could you please test if this fixes your problems?
Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |