Messages in this thread | | | Date | Thu, 9 Jun 2005 20:41:14 +0300 | From | Pekka Enberg <> | Subject | Re: [RFC] SPI core |
| |
Hi,
On Thursday 09 June 2005 16:33, Pekka Enberg wrote: > > Preferred location for EXPORT_SYMBOLs is immediately after the function > > definition.
On 6/9/05, Alexey Dobriyan <adobriyan@gmail.com> wrote: > New files can choose any style.
Sure they can but hopefully they choose a style that make sense. Putting EXPORT_SYMBOLs immediately after function definition makes most sense to me. You can immediately see if a function is exported or not plus you can get listing of all symbols with grep. So there's really no good reason why you should put them at the end of a file (and one good reason to put them after definition).
You are right, though, that authors and maintainers decide what style they use. I only provide suggestions and hope for the best ;).
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |