Messages in this thread Patch in this message | | | Date | Tue, 7 Jun 2005 00:21:51 +0200 | From | Karol Kozimor <> | Subject | Re: [ACPI] Re: Kernel oops with asus_acpi module |
| |
Thus wrote Hanno Böck: > Am Montag, 6. Juni 2005 23:32 schrieb Karol Kozimor: > > May I see the DSDT? The Samsung P30 INIT method referenced in > > asus_hotk_get_info() is not supposed to return anything, not even an empty > > string. I believe the new ACPICA implicit return might be interfering. > > Here's the relevant part of what I based the code on:
Thanks. This might also help:
--- a/drivers/acpi/asus_acpi.c 2005-04-26 00:38:20.000000000 +0200 +++ b/drivers/acpi/asus_acpi.c 2005-06-07 00:18:17.000000000 +0200 @@ -992,7 +992,7 @@ /* Samsung P30 has a device with a valid _HID whose INIT does not * return anything. Catch this one and any similar here */ - if (buffer.pointer == NULL) { + if (buffer.pointer == NULL || buffer.length == 0) { if (asus_info && /* Samsung P30 */ strncmp(asus_info->oem_table_id, "ODEM", 4) == 0) { hotk->model = P30; But I'd like to get the full oops with the matching asus_acpi.o file also (might be off the list).
Best regards,
-- Karol 'sziwan' Kozimor sziwan@hell.org.pl - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |