lkml.org 
[lkml]   [2005]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] shmem: restore superblock info
On Mon, 6 Jun 2005, Hugh Dickins wrote:

> On Mon, 6 Jun 2005, Brent Casavant wrote:
> > On Mon, 6 Jun 2005, Hugh Dickins wrote:
> >
> > > @@ -1607,15 +1582,17 @@ static int shmem_statfs(struct super_blo
> > > - if (sbinfo) {
> > > - spin_lock(&sbinfo->stat_lock);
> > > + spin_lock(&sbinfo->stat_lock);
> ...
> >
> > This is the only change I'm at all concerned about.
>
> Thanks for noticing, I hadn't really considered that.
>
> > I'm not sure how frequent statfs operations occur in practice (I suspect
> > infrequently),
>
> Infrequently, yes. I think infrequently to the point of never in
> the case that concerns you: correct if I'm wrong, someone, but I think
> there's actually no handle by which user can statfs shm's internal mount.

Ah, that's an even better point, which I had failed to consider. Consider
my concerns duly nullified. :)

Thanks for CC'ing me on the change.

Brent

--
Brent Casavant If you had nothing to fear,
bcasavan@sgi.com how then could you be brave?
Silicon Graphics, Inc. -- Queen Dama, Source Wars
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-06 22:45    [W:0.067 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site