Messages in this thread | | | Date | Sun, 5 Jun 2005 16:14:21 +0200 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH Linux 2.6.12-rc5-mm2 08/09] blk: update IDE to use the new blk_ordered. |
| |
On 6/5/05, Jeff Garzik <jgarzik@pobox.com> wrote: > Tejun Heo wrote: > > @@ -176,6 +176,18 @@ static ide_startstop_t __ide_do_rw_disk( > > lba48 = 0; > > } > > > > + if (blk_fua_rq(rq) && > > + (!rq_data_dir(rq) || !drive->select.b.lba || !lba48)) { > > + if (!rq_data_dir(rq)) > > + printk(KERN_WARNING "%s: FUA READ unsupported\n", > > + drive->name); > > + else > > + printk(KERN_WARNING "%s: FUA request received but " > > + "cannot use LBA48\n", drive->name); > > + ide_end_request(drive, 0, 0); > > + return ide_stopped; > > + } > > + > > > Does this string of tests really need to be added to the main fast path? > > It would be better to simply guarantee that this check need never exist > in the IDE driver, by guaranteeing that the block layer will never send > a FUA-READ command to a driver that does not wish it. > > Jeff
Seconded, plus please use <linux/ata.h> instead of <linux/hdreg.h> for adding new opcodes. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |