Messages in this thread | | | Date | Sun, 5 Jun 2005 23:51:08 +0200 | From | Jesper Juhl <> | Subject | Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver |
| |
On 6/3/05, Marcel Holtmann <marcel@holtmann.org> wrote: > Hi Abhay, > > > Resubmitting after cleaning up spaces/tabs etc... > > and now starting with the coding style nitpicking ;) > [snip] > > + if (pbuf != NULL) { > > Make it "if (!pbuf)", > [snip]
You want to make it "if (pbuf)" otherwise you'd be changing the logic.
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |