lkml.org 
[lkml]   [2005]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] 2.6.13-rc1 get_request nastiness
    get_request is now expected to be holding on to queue_lock, with interrupts
    disabled, when it returns NULL; but one path forgot that, causing all kinds
    of nastiness under swap load - badness backtraces, strange failures, BUGs.

    Signed-off-by: Hugh Dickins <hugh@veritas.com>

    --- 2.6.13-rc1/drivers/block/ll_rw_blk.c 2005-06-29 11:54:08.000000000 +0100
    +++ linux/drivers/block/ll_rw_blk.c 2005-06-29 14:41:04.000000000 +0100
    @@ -1917,10 +1917,9 @@ get_rq:
    * limit of requests, otherwise we could have thousands of requests
    * allocated with any setting of ->nr_requests
    */
    - if (rl->count[rw] >= (3 * q->nr_requests / 2)) {
    - spin_unlock_irq(q->queue_lock);
    + if (rl->count[rw] >= (3 * q->nr_requests / 2))
    goto out;
    - }
    +
    rl->count[rw]++;
    rl->starved[rw] = 0;
    if (rl->count[rw] >= queue_congestion_on_threshold(q))
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-06-29 16:18    [W:0.021 / U:2.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site