Messages in this thread | | | Date | Tue, 28 Jun 2005 09:52:37 -0700 | From | Zach Brown <> | Subject | Re: [PATCH 2/6] Rename __lock_page to lock_page_slow |
| |
I have to whine at least once about obscure names :)
> -void fastcall __lock_page(struct page *page) > +void fastcall lock_page_slow(struct page *page) > { > DEFINE_WAIT_BIT(wait, &page->flags, PG_locked); > > __wait_on_bit_lock(page_waitqueue(page), &wait, sync_page, > TASK_UNINTERRUPTIBLE); > } > -EXPORT_SYMBOL(__lock_page); > +EXPORT_SYMBOL(lock_page_slow);
Can we chose a name that describes what it does? Something like lock_page_wait_on_locked()?
- z - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |