lkml.org 
[lkml]   [2005]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] I2C: #include <linux/config.h> cleanup
    Date
    From
    [PATCH] I2C: #include <linux/config.h> cleanup

    Hi Alexey,

    > Files that don't use CONFIG_* stuff shouldn't include config.h
    > Files that use CONFIG_* stuff should include config.h
    >
    > It's that simple. ;-)

    I agree. This won't change anything though, as all drivers include
    either device.h or module.h, which in turn include config.h. But you are
    still correct, so I approve your patch.

    For completeness, I would propose the following on top of your own
    patch:

    i2c bus drivers do not need to define DEBUG themselves, as the Kconfig
    system takes care of it.

    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    commit a551ef79d9413727f76d22dc47b5b15d1d03073b
    tree 4b43e032dc6b6cb5de78ce700b12762ab71483e0
    parent f0bb60e7b1a0a26c25d8cbf81dda7afbc8bd2982
    author Jean Delvare <khali@linux-fr.org> Sat, 16 Apr 2005 18:49:22 +0200
    committer Greg Kroah-Hartman <gregkh@suse.de> Tue, 21 Jun 2005 21:51:53 -0700

    drivers/i2c/busses/i2c-ixp2000.c | 5 -----
    drivers/i2c/busses/i2c-ixp4xx.c | 5 -----
    2 files changed, 0 insertions(+), 10 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-ixp2000.c b/drivers/i2c/busses/i2c-ixp2000.c
    --- a/drivers/i2c/busses/i2c-ixp2000.c
    +++ b/drivers/i2c/busses/i2c-ixp2000.c
    @@ -26,11 +26,6 @@
    * 'enabled' to drive the GPIOs.
    */

    -#include <linux/config.h>
    -#ifdef CONFIG_I2C_DEBUG_BUS
    -#define DEBUG 1
    -#endif
    -
    #include <linux/kernel.h>
    #include <linux/init.h>
    #include <linux/device.h>
    diff --git a/drivers/i2c/busses/i2c-ixp4xx.c b/drivers/i2c/busses/i2c-ixp4xx.c
    --- a/drivers/i2c/busses/i2c-ixp4xx.c
    +++ b/drivers/i2c/busses/i2c-ixp4xx.c
    @@ -26,11 +26,6 @@
    * that is passed as the platform_data to this driver.
    */

    -#include <linux/config.h>
    -#ifdef CONFIG_I2C_DEBUG_BUS
    -#define DEBUG 1
    -#endif
    -
    #include <linux/kernel.h>
    #include <linux/init.h>
    #include <linux/device.h>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-06-22 08:50    [W:0.031 / U:89.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site