lkml.org 
[lkml]   [2005]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC: 2.6 patch] better USB_MON dependencies
On Tue, 21 Jun 2005 16:32:27 +0200, Adrian Bunk <bunk@stusta.de> wrote:

> The patch below tries to solve this in a better way.

> config USB_MON
> - tristate "USB Monitor"
> - depends on USB
> + bool "USB Monitor"
> + depends on USB!=n
> default y

This is a good idea and I wanted to do it for a while, only I was unable
to figure how to write the "depends on USB!=n" part. I'm all for it.
Let me give it a test here just to be sure, but I think we're good.

One question though, do we want this:

> -obj-$(CONFIG_USB_MON) += mon/
> +ifdef CONFIG_USB_MON
> + obj-$(CONFIG_USB) += mon/
> +endif

Seems superfluous to me, because we kept CONFIG_USB_MON. This place should
probably be left alone.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-21 21:41    [W:0.091 / U:2.264 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site