lkml.org 
[lkml]   [2005]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: a trival bug of megaraid in patch 2.6.12-mm1
Date
Quoting bobl <bobl@turbolinux.com>:
> The attachment is the patch, please confirm it.

> diff -purN linux-2.6.12/drivers/scsi/megaraid.c linux-2.6.12.new/drivers/scsi/megaraid.c
> --- linux-2.6.12/drivers/scsi/megaraid.c 2005-06-21 18:49:50.118732304 +0900
> +++ linux-2.6.12.new/drivers/scsi/megaraid.c 2005-06-21 18:57:55.266978560 +0900
> @@ -1975,6 +1975,7 @@ __megaraid_reset(Scsi_Cmnd *cmd)
> static int
> megaraid_reset(Scsi_Cmnd *cmd)
> {
> + adapter_t *adapter;
> adapter = (adapter_t *)cmd->device->host->hostdata;
> int rc;

That's mixed code and declarations (aka Not Good (tm)).
Please do something like this instead:

- adapter = (adapter_t *)cmd->device->host->hostdata;
+ adapter_t *adapter = (adapter_t *)cmd->device->host->hostdata;
int rc;


--
Greetings, Michael


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-06-21 12:24    [W:0.034 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site