lkml.org 
[lkml]   [2005]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH: Fix crashes with hotplug serverworks
On 6/21/05, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Maw, 2005-06-21 at 07:52, Christoph Hellwig wrote:
> > Well, because of fake-hotplug we really need to mark every ->probe routine
> > and what's called from it __devinit. Debian has patch to do that forever
> > but Bart refused to take it.
>
> I'm not surprised from our experience either.

Get a life.

> Actually marking all the devices __devinit may be overkill. One approach
> that does also seem to work is passing "hotplug yes/no" information when
> registering the driver. This is then used to run the ide scan at boot
> and avoid registering that driver with the PCI core for hotplug.

* with fake-hotplug driver you always need "hotplug yes"
* these drivers have to be registered with PCI core

> A move to __devinit is certainly simpler.

This is a correct fix.

Bartlomiej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-21 12:08    [W:0.136 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site