lkml.org 
[lkml]   [2005]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] drivers/char/tipar.c: off by one array access
    randy_dunlap wrote:
    > On Sun, 19 Jun 2005 17:15:30 +0200 Luc Van Oostenryck wrote:
    >
    > | In the setupt function, the delay variable is initialized with ints[2],
    > | but ints is declared as:
    > | int ints[2];
    > |
    > | Since the module parameter should correspond to:
    > | tipar=timeout,delay
    > |
    > | I suppose that the following patch fix the problem.

    ...

    >
    > That (re)uses the timeout value for delay.
    > Please try again....
    >
    > get_options() sets ints[0] to the number of parameters parsed
    > and tipar_setup() clearly wants to parse as you described:
    > | tipar=timeout,delay
    > so the ints[] array needs to be [3], not [2].
    >
    > ---
    > ~Randy

    Yes, sorry. Here is another patch.

    Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@looxix.net>

    diff --git a/drivers/char/tipar.c b/drivers/char/tipar.c
    --- a/drivers/char/tipar.c
    +++ b/drivers/char/tipar.c
    @@ -396,7 +396,7 @@ static struct file_operations tipar_fops
    static int __init
    tipar_setup(char *str)
    {
    - int ints[2];
    + int ints[3];

    str = get_options(str, ARRAY_SIZE(ints), ints);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-06-21 07:25    [W:0.038 / U:93.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site