lkml.org 
[lkml]   [2005]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver
From
Date
Hi Abhay,

> This is a resubmit of the patch after incorporating all the inputs from revieweres.
> This has the hotplug firmware interface as suggested by many.
> Currently it does not suport reading back the data; I am workingon it and will add
> that feature as new patch.

please fix the coding style. We use tabs instead of spaces.

Make sure that all functions are static and clean your namespace. Even
if they are static it is still unclean.

It is <linux/firmware.h> and not "linux/firmware.h".

The Kconfig is missing a "select FW_LOADER".

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-03 00:06    [W:0.035 / U:4.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site