lkml.org 
[lkml]   [2005]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2/5] x86_64: CPU hotplug support.
On Thu, 2 Jun 2005, Ashok Raj wrote:

> @@ -445,8 +477,10 @@ void __cpuinit start_secondary(void)
> /*
> * Allow the master to continue.
> */
> + lock_ipi_call_lock();
> cpu_set(smp_processor_id(), cpu_online_map);
> mb();
> + unlock_ipi_call_lock();

What's that? Is this another smp_call_function race workaround? I thought
there was an additional patch to avoid the broadcast.

> +#include <asm/nmi.h>
> +/* We don't actually take CPU down, just spin without interrupts. */
> +static inline void play_dead(void)
> +{
> + idle_task_exit();
> + mb();
> + /* Ack it */
> + __get_cpu_var(cpu_state) = CPU_DEAD;
> +
> + local_irq_disable();
> + while (1)
> + safe_halt();
> +}

Might as well drop the local_irq_disable since safe_halt enables
interrupts.

Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-02 22:41    [W:0.120 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site