lkml.org 
[lkml]   [2005]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC: 2.6 patch] net/ipv4/: possible cleanups
From
From: Adrian Bunk <bunk@stusta.de>
Subject: [RFC: 2.6 patch] net/ipv4/: possible cleanups
Date: Mon, 30 May 2005 22:56:51 +0200

> This patch contains the following possible cleanups:
> - make needlessly global code static
> - #if 0 the following unused global function:
> - xfrm4_state.c: xfrm4_state_fini
> - remove the following unneeded EXPORT_SYMBOL's:
> - ip_output.c: ip_finish_output
> - ip_output.c: sysctl_ip_default_ttl
> - fib_frontend.c: ip_dev_find
> - inetpeer.c: inet_peer_idlock
> - ip_options.c: ip_options_compile
> - ip_options.c: ip_options_undo
> - tcp_ipv4.c: sysctl_max_syn_backlog
>
> Please review which of these changes are correct and which might
> conflict with pending patches.

Please keep all of the ECN implementation in the
tcp_ecn.h header file, even if the routine is only
called in one C file.

And therefore, please do not remove the tcp_enter_quickack_mode()
extern declaration from tcp.h

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-02 22:23    [W:0.050 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site