Messages in this thread | | | From | Ingo Oeser <> | Subject | Re: [rfc] [patch] consolidate/clean up spinlock.h files | Date | Thu, 2 Jun 2005 18:30:03 +0200 |
| |
Hi Ingo,
Ingo Molnar wrote: > * Ingo Oeser <ioe-lkml@axxeo.de> wrote: > > you wrote: > > > --- linux/lib/spinlock_debug.c.orig > > I would suggest propagating the __FILE__ and __LINE__ from the CALLERS > the real call site info comes from dump_stack(). Maybe i should remove > the __FILE__,__LINE__ info altogether. (albeit a bit redundancy wont > hurt) I dont think we want to pass in __FILE__,__LINE__ all the way from > the main APIs.
Then please remove the __FILE__ and __LINE__ altogether.
It looks confusing to me and enlarges code without providing any useful additional information.
Regards
Ingo Oeser
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |